Repository navigation
test(team): M15 real-model Team mode security suite - #4304
Merged
Merged
Conversation
Member Bot commands run in a bwrap profile that hides DSH_HOME, homes, /run and other Bots' Memory and Workspaces, binds back only the Session roots, removes secret environment variables, and joins a private network namespace that denies the Host loopback, link-local, private and tailnet ranges. Team mode reports enforced isolation only when both work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lpx6qkvJqKRjdg67NfFT7X
The hidden space name started with a NUL byte. SQLite NOCASE comparison stops at NUL, so every public Bot's space name compared equal and the second publication on a Host failed the shared-name unique index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lpx6qkvJqKRjdg67NfFT7X
scripts/e2e-team-security.mjs sets up roles with Role Policy, members, public and private Bots, folders and Channels on an isolated Host and drives real model turns that try to leak restricted figures, reach other members' folders, the Host data directory and the Host API through file tools, Shell and grants, and cross private Bots, Channels, DMs, offboarding and model allowlists. Hard boundaries are asserted on Host state and tool results. AGENTS.md requires its report for every PR that changes Team mode permissions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lpx6qkvJqKRjdg67NfFT7X
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
# Conflicts: # packages/core/test/team-public-bot-memory.test.ts
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lpx6qkvJqKRjdg67NfFT7X
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
Team mode needs a kept, re-runnable suite. It tries to break the permission model the way a real user would, with real model turns, and it gates every permission-affecting PR.
Closes #4197
Stacked on #4277 (M12 confinement), which the issue lists as a blocker. It also carries the cherry-picked #4298 fix, which this suite found. Retarget to
mainafter both merge.Special things to note
--publicBot worked. Every later publication returnedinternalbecause hidden space names collided under SQLiteNOCASEafter a NUL byte. Fixed in fix(team): give each public Bot's hidden Memory space a distinct name #4298, with a regression test.opencode-go/deepseek-v4.1-flash,isolation: enforced.node scripts/e2e-team-security.mjs --launchon headed3c34b3, using a fresh Host home.deepseek-official/deepseek-flash,isolation: enforced, head1a38edc7, fresh Host home. Result: 11/11 passed. Report: https://media.botharness.ai/pr/1a38edc72024/808490b4cf1e48ea3de54faccde98b1a610d3593a085647e234b3651e2271fa9.htmlteam-mode statusreportsisolation: enforced; elsewhere the suite reports the known gap.npm installfrom the confined Shell are tracked on feat(team): confine member Bot commands on Linux Hosts #4277 (VPS acceptance).verification-inventory.jsonas mapped to the newteam.security-suitebehavior, andpnpm lintpasses.Change outline
speaker-policy, A3 Allow+Deny, A4 mixed Group, A5 role revoked mid-conversation.credentials.yaml,..and symlink), B2 Shell script (same targets,grep -rDSH_HOME,find /, write outside, secret env, Host API port), B3 grant requestsbot-not-found,remote-access/denied), allowlist notall, deactivated member refused.Docs:
features/team-mode.md,docs/agents/development-scripts.md, and the change fragment.Generated by Claude Code